Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Always sort deletes before inserts for the same table to avoid deadlocks. #25952

Merged
merged 1 commit into from
Sep 10, 2021
Merged

Always sort deletes before inserts for the same table to avoid deadlocks. #25952

merged 1 commit into from
Sep 10, 2021

Conversation

AndriySvyryd
Copy link
Member

This dependency isn't hard, so cycle breaking is introduced.
Make the implementations of Multigraph TopologicalSort and BatchingTopologicalSort more alike and faster

Fixes #14371

@AndriySvyryd
Always sort deletes before inserts for the same table to avoid deadlo…
4ecc826 
…cks.

This dependency isn't hard, so cycle breaking is introduced.
Make the implementations of Multigraph TopologicalSort and BatchingTopologicalSort more alike and faster

Fixes #14371
@AndriySvyryd AndriySvyryd requested a review from a team September 9, 2021 03:27
ajcvickers
ajcvickers approved these changes Sep 10, 2021
View reviewed changes
Copy link
Member

@ajcvickers ajcvickers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not going to say I fully understand the changes to the graph code, but all the existing tests still pass, so looks good to me. :-)

@AndriySvyryd AndriySvyryd merged commit e1de574 into release/6.0 Sep 10, 2021
@AndriySvyryd AndriySvyryd deleted the Issue14371 branch September 10, 2021 05:05
@AndriySvyryd AndriySvyryd mentioned this pull request Sep 17, 2021
Merged
@ajcvickers ajcvickers mentioned this pull request Sep 23, 2021
Closed
This was referenced Dec 10, 2021
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ajcvickers ajcvickers ajcvickers approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Transaction deadlocks within a simple DB model
2 participants
@AndriySvyryd @ajcvickers